fix(typescript): update to typescript with fixed system emit#3594
Closed
alexeagle wants to merge 1 commit intoangular:masterfrom
Closed
fix(typescript): update to typescript with fixed system emit#3594alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle wants to merge 1 commit intoangular:masterfrom
Conversation
alexeagle
added
action: review
Contributor
|
This branch can be merged in without breaking Angular. This fixes the bugs that we were having with TypeScript transcompilation to System.register format. This does require systemjs to be updated to 0.18.3. Should I look at making a PR to update systemjs and switching Angular to your updated compiler? @alexeagle |
Contributor
Author
|
Sure you could make a PR to take next steps. (this PR does switch to the updated compiler though) |
mary-poppins
removed
the
action: merge
|
Merging PR #3594 on behalf of @tbosch to branch presubmit-tbosch-pr-3594. |
tbosch
removed
the
action: review
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up two commits from our TypeScript fork:
alexeagle/TypeScript@90373cd...alexeagle:1.5_error_is_class