fix(benchmarks): remove reference to String.prototype.contains()#3570
Closed
caitp wants to merge 1 commit intoangular:masterfrom
Closed
fix(benchmarks): remove reference to String.prototype.contains()#3570caitp wants to merge 1 commit intoangular:masterfrom
caitp wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
StringWrapper is in angular2/src/facade/lang...
tbosch
added
pr_state: LGTM
action: cleanup
https://github.com/tc39/tc39-notes/blob/master/es6/2014-11/nov-18.md#51--44-arrayprototypecontains-and-stringprototypecontains removed String.prototype.contains() from standard, and is not implemented in most runtimes (SpiderMonkey still being an exception).
caitp
force-pushed
the
it-doesnt-really-exist
branch
from
55cf0f6 to
640d0ca
Compare
|
Merging PR #3570 on behalf of @tbosch to branch presubmit-tbosch-pr-3570. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/tc39/tc39-notes/blob/master/es6/2014-11/nov-18.md#51--44-arrayprototypecontains-and-stringprototypecontains
removed String.prototype.contains() from standard, and is not
implemented in most runtimes (SpiderMonkey still being an exception).