typings: add ability to specify reference paths and ambient module name#3544
Closed
jeffbcross wants to merge 2 commits intoangular:masterfrom
Closed
typings: add ability to specify reference paths and ambient module name#3544jeffbcross wants to merge 2 commits intoangular:masterfrom
jeffbcross wants to merge 2 commits intoangular:masterfrom
Conversation
jeffbcross
added
feature
Contributor
Author
jeffbcross
force-pushed
the
typing-references
branch
2 times, most recently
from
50be427 to
c526da2
Compare
alexeagle
added
pr_state: LGTM
and removed
action: review
Without this feature, each bundle would have to create its own typings template to include references to dependent typings. Now, the references can be declared in JS, along with other meta information about the bundle typings. Closes angular#3540
Allows declaring a bundle's namespace in generated typings file,
which should correspond to the global object representing the module
inside its bundle.
BREAKING CHANGE
The router was previously exported as ng.router in the
angular.sfx.dev.js bundle, but now it is exported as ngRouter.
Closes angular#2948
jeffbcross
force-pushed
the
typing-references
branch
from
c526da2 to
a97e159
Compare
|
User @jeffbcross does not have PR merging privlidges. |
mary-poppins
removed
the
action: merge
Contributor
Author
|
Whatever, @mary-poppins |
goderbauer
pushed a commit
to goderbauer/angular
that referenced
this pull request
Aug 15, 2015
Allows declaring a bundle's namespace in generated typings file,
which should correspond to the global object representing the module
inside its bundle.
BREAKING CHANGE
The router was previously exported as ng.router in the
angular.sfx.dev.js bundle, but now it is exported as ngRouter.
Closes angular#2948
Closes angular#3544
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.