feat(ivy): improve ExpressionChangedAfterChecked error message for text interpolations#34520
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
…text interpolations This commit improves ExpressionChangedAfterChecked error message for text interpolations by including the content of entire expression that contains interpolation(s). In order to achieve that, metadata for text interpolations is now stored in TData array when textInterpolate instructions are being called (similar to property and propertyInterpolate instructions).
AndrewKushnir
added
feature
6 tasks
Contributor
Author
|
We should probably change error message format for text interpolations from: to: That should help find an expression that was changed: old and new values are displayed and the entire text interpolation content is included for the context. |
3 tasks
pkozlowski-opensource
added
the
area: core
Contributor
Author
|
Closing this PR for now (it's in a non-mergeable state). |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves ExpressionChangedAfterChecked error message for text interpolations by including the content of entire expression that contains interpolation(s). In order to achieve that, metadata for text interpolations is now stored in TData array when textInterpolate instructions are being called (similar to property and propertyInterpolate instructions).
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?