feat(ivy): improve ExpressionChangedAfterChecked error message for attributes#34505
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
feat(ivy): improve ExpressionChangedAfterChecked error message for attributes#34505AndrewKushnir wants to merge 1 commit intoangular:masterfrom
ExpressionChangedAfterChecked error message for attributes#34505AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
AndrewKushnir
added
type: bug/fix
target: patch
6 tasks
AndrewKushnir
added
the
action: review
AndrewKushnir
added
feature
…attributes This commit improves `ExpressionChangedAfterChecked` error message for attributes by including attribute name and the content of the entire expression that contains interpolation(s). In order to achieve that, metadata is now stored in `TData` array when `attribute` and `attributeInterpolate` instructions are being called (similar to `property` and `propertyInterpolate` instructions).
AndrewKushnir
force-pushed
the
cd_error_details_for_attrs
branch
from
001d288 to
f515947
Compare
AndrewKushnir
changed the title
ExpressionChangedAfterChecked error message for attributesExpressionChangedAfterChecked error message for attributes
| import {getLView, getSelectedIndex, nextBindingIndex} from '../state'; | ||
|
|
||
| import {elementAttributeInternal} from './shared'; | ||
| import {elementAttributeInternal, storePropertyBindingMetadata} from './shared'; |
Member
There was a problem hiding this comment.
nit: what do you think of renaming storePropertyBindingMetadata to storeBindingMetadata (since now it is applied to both property bindings, attributes, interpolations etc.)?
pkozlowski-opensource
approved these changes
Jan 9, 2020
Member
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM, left one nit comment to be resolved at your discretion
pkozlowski-opensource
removed
the
action: review
Member
|
Oh, I can see that you've changed the |
pkozlowski-opensource
added
the
action: merge
AndrewKushnir
added
the
action: presubmit
Contributor
Author
Contributor
Author
|
Thanks for the review @pkozlowski-opensource! 👍 |
AndrewKushnir
removed
the
action: presubmit
atscott
pushed a commit
that referenced
this pull request
Jan 9, 2020
…attributes (#34505) This commit improves `ExpressionChangedAfterChecked` error message for attributes by including attribute name and the content of the entire expression that contains interpolation(s). In order to achieve that, metadata is now stored in `TData` array when `attribute` and `attributeInterpolate` instructions are being called (similar to `property` and `propertyInterpolate` instructions). PR Close #34505
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves
ExpressionChangedAfterCheckederror message for attributes by including attribute name and the content of the entire expression that contains interpolation(s). In order to achieve that, metadata is now stored inTDataarray whenattributeandattributeInterpolateinstructions are being called (similar topropertyandpropertyInterpolateinstructions).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?