X Tutup
Skip to content

fix(browser_adapter): fix clearNodes() in IE #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkozlowski-opensource wants to merge 1 commit into from
Closed

fix(browser_adapter): fix clearNodes() in IE #3355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/angular2/src/dom/browser_adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,14 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
}
clearNodes(el) {
while (el.firstChild) {
el.firstChild.remove();
el.removeChild(el.firstChild);
Copy link
Copy Markdown
Contributor

@PatrickJS PatrickJS Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you write a comment that can explain the reason why the refactor is needed or simply a comment with a url to the issue

Copy link
Copy Markdown
Member Author

@pkozlowski-opensource pkozlowski-opensource Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdi2290 this commit has a reference to the original issue, so hopfully it should be enough. And as soon as we plug other browsers on the CI it will be self-verifying.

Copy link
Copy Markdown
Contributor

@PatrickJS PatrickJS Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right I jumped to conclusion and we have github/git blame/CI for a reason. If someone were to optimize this they would first check git blame then the git commit history before proceeding and if that fails CI will prevail. With all that said, comments are important to show hot path, document unorthodox/failed optimizations, unimportant technical debt via TODO:, or code documentation

}
}
appendChild(el, node) { el.appendChild(node); }
removeChild(el, node) { el.removeChild(node); }
replaceChild(el: Node, newChild, oldChild) { el.replaceChild(newChild, oldChild); }
remove(node): Node {
node.remove();
node.parentNode.removeChild(node);
return node;
}
insertBefore(el, node) { el.parentNode.insertBefore(node, el); }
Expand Down
X Tutup