feat(compiler): introduce schema for elements#3353
feat(compiler): introduce schema for elements#3353pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
pkozlowski-opensource
force-pushed
the
registry_new
branch
2 times, most recently
from
4ee7091 to
af25bae
Compare
|
@tbosch this is the re-done PR for elements schema support. I believe that I've addressed all the comments from yesterday: we've got a minimal API / set of changes here to support property bindings to work as today. We can build on top of this later on (events, attributes etc.) Could you PTAL? |
pkozlowski-opensource
added
the
action: review
There was a problem hiding this comment.
Yes and no.
The method isValidElementPropertyBindings is used for host properties and regular property bindings. For host properties, we should only check DOM properties. Previously we used the knowledge of whether this as an ng component to assume that it is not a custom element, and therefore could call DOM.hasProperty().
For regular property bindings you are right in that for ng components we should only allow properties of that component.
tbosch
added
action: cleanup
|
Looks good, except for the comment above. Could you clean this up? |
pkozlowski-opensource
force-pushed
the
registry_new
branch
from
af25bae to
0e80f6a
Compare
|
@tbosch removed checks for directive properties on host elements and landed it. Will follow up with issues for missing features (events, attributes) and PRs targeting custom components. |
|
But you kept the |
|
@tbosch yes, will sent PRs with additional tests / comments first thing tomorrow. Just wanted to land this one so it doesn't get bit-rotten. |
|
ok On Wed, Jul 29, 2015 at 10:47 AM Pawel Kozlowski notifications@github.com
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
No description provided.