X Tutup
Skip to content

feat(query): allow to query for TemplateRef#3202

Closed
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:query-template
Closed

feat(query): allow to query for TemplateRef#3202
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:query-template

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented Jul 22, 2015

Part of #1989

@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 22, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a check on the list of both to make sure they are equal to 1.

@rkirov rkirov added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 27, 2015
@rkirov
Copy link
Copy Markdown
Contributor

rkirov commented Jul 27, 2015

A few small changes, otherwise LGTM. In general I wonder if we need to expose some other pre-built objects?

@mhevery mhevery assigned tbosch and unassigned rkirov Aug 10, 2015
@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Aug 10, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #3202 on behalf of @tbosch to branch presubmit-tbosch-pr-3202.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 10, 2015
@tbosch tbosch closed this Aug 11, 2015
@tbosch tbosch deleted the query-template branch August 11, 2015 23:30
@tbosch tbosch restored the query-template branch August 11, 2015 23:31
@tbosch tbosch reopened this Aug 11, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #3202 on behalf of @tbosch to branch presubmit-tbosch-pr-3202.

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Aug 12, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 12, 2015
@tbosch tbosch closed this in 585ea5d Aug 12, 2015
goderbauer pushed a commit to goderbauer/angular that referenced this pull request Aug 15, 2015
@tbosch tbosch deleted the query-template branch September 25, 2015 14:31
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup