perf(dom): Only send values for existing properties to js interior#3149
Closed
tbosch wants to merge 1 commit intoangular:masterfrom
Closed
perf(dom): Only send values for existing properties to js interior#3149tbosch wants to merge 1 commit intoangular:masterfrom
tbosch wants to merge 1 commit intoangular:masterfrom
Conversation
Due to angular#3019 we have to check whether a property exists on a DOM element not before runtime of the application. Previously, we did this check in JavaScript, making all property values go through dart js interop. However, this is slow for complex objects. This commit changes this behavior to first check whether the property exists before sending the property value to the DOM element via js interop.
yjbanov
added
pr_state: LGTM
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to #3019 we have to check whether a property exists on a DOM element
not before runtime of the application.
Previously, we did this check in JavaScript, making all property values
go through dart js interop. However, this is slow for complex objects.
This commit changes this behavior to first check whether the property exists
before sending the property value to the DOM element via js interop.