feat(pipes): add intl (number and date) pipes#2877
Closed
piloopin wants to merge 2 commits intoangular:masterfrom
Closed
feat(pipes): add intl (number and date) pipes#2877piloopin wants to merge 2 commits intoangular:masterfrom
piloopin wants to merge 2 commits intoangular:masterfrom
Conversation
Contributor
|
Could you split this PR into four separate PRs? The number and dates pipes are non-controversial and can be merged with a few minor changes. The last two commits are a bit trickier. For instance, the way you use Parser to get AST nodes, which you then call eval on, will not work with Dart transformers. We need to think a little bit more about it. |
Contributor
Author
Contributor
|
@piloopin Thank you. I will merge this PR today. |
9 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2340.