X Tutup
Skip to content

feat(build): Allow building in windows#2873

Closed
alfonso-presa wants to merge 1 commit intoangular:masterfrom
alfonso-presa:WindowsBuild
Closed

feat(build): Allow building in windows#2873
alfonso-presa wants to merge 1 commit intoangular:masterfrom
alfonso-presa:WindowsBuild

Conversation

@alfonso-presa
Copy link
Copy Markdown
Contributor

While trying to build this in my windows machine a saw that symlinking is not working properly. It was easy to fix by falling back to hard copying files in case of linking failure.

Hope you find this useful for us, windows users....

Thanks!

@alfonso-presa alfonso-presa force-pushed the WindowsBuild branch 2 times, most recently from 6c6dcb0 to a1466f2 Compare July 4, 2015 15:51
@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 7, 2015
@marclaval marclaval added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 8, 2015
@marclaval
Copy link
Copy Markdown
Contributor

On the bright side, it solves the build issue when the current user doesn't have the permission for symbolic links.

On the other side, it makes everything much slower ...
On top of that, the incremental build is broken when running tests with watchers (both test.unit.js and test.unit.dart tasks), i.e. files modifications are not taken into account. Note that this is not a new issue introduced by this PR.

So LGTM but the limitations should be documented in the developer guide.

@alfonso-presa
Copy link
Copy Markdown
Contributor Author

You're right... incremental builds will still not work with this patch. I've uploaded a new version with the developer guide's note and also refactored a little bit the copyRecursiveSync method.

Thank you!

@tbosch tbosch closed this in f1f5784 Jul 8, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup