X Tutup
Skip to content

refactor(RegExp): use /.../ to create RegExp literal#2695

Closed
vicb wants to merge 1 commit intoangular:masterfrom
vicb:0623-regexp
Closed

refactor(RegExp): use /.../ to create RegExp literal#2695
vicb wants to merge 1 commit intoangular:masterfrom
vicb:0623-regexp

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Jun 23, 2015

Review on Reviewable

@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup labels Jun 23, 2015
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jun 23, 2015

@pkozlowski-opensource I'll squash the other PR here

@vicb vicb mentioned this pull request Jun 23, 2015
Closed
@vicb vicb added state: blocked and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 23, 2015
vicb
vicb reviewed Jun 23, 2015
View reviewed changes
modules/angular2/src/render/dom/shadow_dom/shadow_css.ts Outdated
Copy link
Copy Markdown
Contributor Author

@vicb vicb Jun 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mprobst clang oops !

@vicb vicb mentioned this pull request Jun 23, 2015
Closed
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jun 23, 2015

blocked on dart-archive/ts2dart#219

@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Jun 24, 2015
Closed
@vicb vicb mentioned this pull request Jun 26, 2015
Closed
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jun 29, 2015

@vicb is this still blocked as the issue in ts2dart is merged?

@tbosch tbosch assigned vicb and unassigned mprobst Jun 29, 2015
@tbosch tbosch added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed state: blocked labels Jun 29, 2015
@vicb vicb assigned tbosch and unassigned vicb Jul 1, 2015
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jul 1, 2015

@tobias rebased - yet to be tested on Travis (the build is broken)

Note: there is still an issue with clang-format it explains why it has been disabled on some sections

@tbosch tbosch assigned vicb and unassigned tbosch Jul 1, 2015
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jul 2, 2015

Try to make your lines shorter. Clang-format has a bug when the line is
close to the 120chars limit...
Otherwise try to turn off clang-format, see element_injector_spec.ts on the
top

On Wed, Jul 1, 2015 at 8:49 AM Victor Berchet notifications@github.com
wrote:

@tobias https://github.com/Tobias rebased - yet to be tested on Travis
(the build is broken)

Note: there is still an issue with clang-format it explains why it has
been disabled on some sections

—
Reply to this email directly or view it on GitHub
#2695 (comment).

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jul 2, 2015

blocked on dart-archive/ts2dart#235

@vicb vicb added state: blocked and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 2, 2015
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jul 8, 2015

@mprobst ptal

@tbosch tbosch assigned mprobst and unassigned vicb Jul 8, 2015
@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 8, 2015
mprobst
mprobst reviewed Jul 9, 2015
View reviewed changes
modules/angular2/src/render/api.ts
Copy link
Copy Markdown
Contributor

@mprobst mprobst Jul 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I think within modules, there really isn't much of a need for static fields, top level variables are entirely fine and require less syntactic bruhaha. But whatever you like better is fine.

@mprobst mprobst added the action: merge The PR is ready for merge by the caretaker label Jul 9, 2015
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jul 9, 2015

landed as 447926d

@vicb vicb closed this Jul 9, 2015
@vicb vicb deleted the 0623-regexp branch July 9, 2015 07:15
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mprobst mprobst

Labels

action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes refactoring Issue that involves refactoring or code-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vicb @tbosch @mprobst @pkozlowski-opensource @googlebot
X Tutup