X Tutup
Skip to content

fix(transformer): Throw unimplemented errors in HtmlAdapter. #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakemac53 wants to merge 1 commit into from
Closed

fix(transformer): Throw unimplemented errors in HtmlAdapter. #2627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions modules/angular2/src/dom/html_adapter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,15 @@ class Html5LibDomAdapter implements DomAdapter {
clearNodes(el) {
throw 'not implemented';
}
appendChild(el, node) => null;
appendChild(el, node) => el.append(node.remove());
removeChild(el, node) {
throw 'not implemented';
}
remove(el) => null;
insertBefore(el, node) => null;
remove(el) => el.remove();
insertBefore(el, node) {
if (el.parent == null) throw '$el must have a parent';
el.parent.insertBefore(node, el);
}
insertAllBefore(el, nodes) {
throw 'not implemented';
}
Expand Down Expand Up @@ -229,9 +232,11 @@ class Html5LibDomAdapter implements DomAdapter {
getAttribute(element, String attribute) {
throw 'not implemented';
}
setAttribute(element, String name, String value) => null;
setAttribute(element, String name, String value) {
element.attributes[name] = value;
}
removeAttribute(element, String attribute) {
throw 'not implemented';
element.attributes.remove(attribute);
}

templateAwareRoot(el) => el;
Expand Down
X Tutup