[WIP] Support relative urls in Component & View#2593
[WIP] Support relative urls in Component & View#2593vicb wants to merge 1 commit intoangular:masterfrom
Conversation
There was a problem hiding this comment.
Why pass in the type and not the annotation?
There was a problem hiding this comment.
for Dart, check the line below.
baseUrl.here is only a placeholder in Dart (the enum above) that has to be a compile time constant
There was a problem hiding this comment.
We will need to move this into a separate import, along with the import to 'dart:mirrors'. I can probably just do this when I update the transformer though.
There was a problem hiding this comment.
@vicb please address @jakemac53 comment. We can't have mirrors. For any mirrors code we must be able to replace it with a different code which is mirror independent during transformers.
There was a problem hiding this comment.
Can't we use the same stacktrace trick in Dart as well? We don' t need the mirrors at all then?
There was a problem hiding this comment.
No problem, I'll work on it tomorrow morning and then I'll be off until Monday.
There was a problem hiding this comment.
@jakemac53 What are your thoughts about stack traces vs mirrors/transformers for Dart ?
print(new Trace.current().frames.map((f) => f.uri).toList()); (Trace is from the pub package stack_trace) seems to work fine.
However I feel like mirrors/transformers could be more solid... (as it does not depend on the underlying browser)
There was a problem hiding this comment.
It seems to me like the mirrors version would be less fragile?
There was a problem hiding this comment.
+1
quick question: what happens if you can not get a package:// url as of today (the component is located in one of your app folder), is this currently supported ?
There was a problem hiding this comment.
Not sure exactly what you mean, but package: urls and relative urls should be supported. Are you talking about pointing to a file in say web from test?
|
Can you look at #2593 (comment) first? |
Yep, seen it. It's a GREAT idea. I should also be able to remove the |
|
Please consider Safari and SystemJS: |
|
I don't think it has ever been blocked but it takes time as it is non trivial. Working on this today an next week. |
|
@vicb can you provide an update? is this still likely to land by july 6? |
|
@vicb Did you close this on purpose? |
|
@tbosch this has been closed because it uses stack traces which does not work cross browsers. I'll detail all of this in a doc. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Warning: early proto.
The hello world example is working with a
templateUrl(Dart & JS).Thoughts ?
/cc @mhevery @jakemac53 @tbosch
TODO: