fix(views): remove dynamic component views, free host views, free emb…#2571
Merged
tbosch merged 1 commit intoangular:masterfrom Jun 17, 2015
Merged
fix(views): remove dynamic component views, free host views, free emb…#2571tbosch merged 1 commit intoangular:masterfrom
tbosch merged 1 commit intoangular:masterfrom
Conversation
tbosch
force-pushed
the
simplify-dcl
branch
2 times, most recently
from
b18493c to
613ef87
Compare
Contributor
Author
|
Reviewed in person with @vsavkin |
…edded views Closes angular#2472 Closes angular#2339 BREAKING CHANGE - `Compiler.compile` has been removed, the only way to compile components dynamically is via `Compiler.compileInHost` - `DynamicComponentLoader.loadIntoExistingLocation` has changed: * renamed into `loadIntoLocation` * will always create the host element as well * requires an element with a variable inside of the host component view next to which it will load new component. - `DynamicComponentLoader.loadNextToExistingLocation` was renamed into `DynamicComponentLoader.loadNextToLocation` - `DynamicComponentLoader.loadIntoNewLocation` is removed * use `DynamicComponentLoader.loadNextToLocation` instead and then move the view nodes manually around via `DomRenderer.getRootNodes()` - `AppViewManager.{create,destroy}Free{Host,Embedded}View` was removed * use `AppViewManager.createViewInContainer` and then move the view nodes manually around via `DomRenderer.getRootNodes()` - `Renderer.detachFreeView` was removed. Use `DomRenderer.getRootNodes()` to get the root nodes of a view and detach them manually.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…edded views
Closes #2472
Closes #2339
BREAKING CHANGE
DynamicComponentLoader.loadInto{Existing,New}Locationis removedDynamicComponentLoader.loadNextToLocationinsteadDynamicComponentLoader.loadNextToExistingLocationwas renamed intoDynamicComponentLoader.loadNextToLocationAppViewManager.{create,destroy}Free{Host,Embedded}Viewwas removedAppViewManager.createViewInContainerand then move the view nodesmanually around via
DomRenderer.getRootNodes()