feat(broccoli): allow rebuild() to return DiffResult#2514
feat(broccoli): allow rebuild() to return DiffResult#2514caitp wants to merge 1 commit intoangular:masterfrom
Conversation
|
@IgorMinar I've experimented with converting plugins to return DiffResults, but have had (once again) issues with dead symlinks, relating to either MultiCopy or some of the Stew plugins. So it might need some work. The performance for subsequent builds does seem to be very good when the build works correctly though (with just a handful of plugins updated) ~on the order of 25ms per tree |
caitp
added
feature
There was a problem hiding this comment.
returning a promise for a diffresult should be possible too. no?
There was a problem hiding this comment.
It is, and there's code handling that case here --- but it seems weird to have Promise<any> | Promise<DiffResult>, since any is kind of catch-all
There was a problem hiding this comment.
how about Promise<undefined|DiffResult>?
IgorMinar
added
action: cleanup
|
I think that addresses each comment |
Plugins may opt to return a DiffResult themselves, and avoid the need to calculate a diff
There was a problem hiding this comment.
Please add a comment that this.treeDiffer attempts to reads the diff from the input tree where we stash after the rebuild of that tree is done.
|
otherwise this looks good |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
Plugins may opt to return a DiffResult themselves, and avoid the
need to calculate a diff