I don't really like this because it doesn't solve the problem that the id of the document should IMO include information (as a string) about the extend parentage of the class. I think the document's id should just be the class name prefixed by module.

We should expose the heritage in separate properties that can be consumed by the .d.ts processing. This would keep the readTypeScriptModules processor decoupled from the final output format.

@petebacondarwin I'm not following. You say "the id of the document should IMO include information (as a string) about the extend parentage of the class." And then you say, "the document's id should just be the class name prefixed by module." I think you used incorrect terminology in one of those sentences.

In my commit, the id remains a string with parentage information, but additional aliases are added to include the full parentage and generic information, as well as a trimmed version.

BTW, this is my first foray into Dgeni, so I'm kinda flying blind. When you say "consumed by the .d.ts processing," are you referring to the logic contained within the readTypeScriptModules.js module?

(Updated the commit to include inline comment about the change, and to fix a link in annotations.ts)

Sorry I mean IMO "not" include that information.

You are flying straight and true - just don't let go of the stick.

What I am saying is that Alex Eagle's change was wrong, that it should be reverted and a different solution found.

@petebacondarwin sounds good, I'll go ahead and revert it and push to this PR.

Hmm, that commit does a lot of things. I'd rather not revert the commit, and I'm not sure the implications if I just remove parts of it.

How about I change my commit to set the id of the doc to the trimmed version, and keep the name as-is? Then existing links should be happy, and the templates would still be displaying the name with full heritage.

Working in it right now.

Closed in favor of 659adf8

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}