feat(http): add basic http service#2360
Conversation
jeffbcross
added
feature
modules/angular2/http.ts
Outdated
There was a problem hiding this comment.
the pattern seems to be httpInjectables
https://github.com/angular/angular/blob/master/modules/angular2/router.ts#L33
https://github.com/angular/angular/blob/master/modules/angular2/router.ts#L33
could you also export Http, HttpFactory, XHRBackend, and BrowserXHR for users who want to overwrite/replace/remake etc
|
Thanks for all the comments, @gdi2290! |
There was a problem hiding this comment.
remove args for symmetry
|
@vsavkin did you have any other feedback other than what we captured on our call? (If not, can you add lgtm label?) |
|
@jeffbcross no, just make Travis happy! |
vsavkin
added
action: cleanup
This implementation only works in JavaScript, while the Observable transpilation story gets worked out. Right now, the service just makes a simple request, and returns an Observable of Response. Additional functionality will be captured in separate issues. Fixes angular#2028
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
5 participants
TODO:
This implementation only works in JavaScript, while the Observable transpilation
story gets worked out. Right now, the service just makes a simple request,
and returns an Observable of Response.
Fixes #2028