feat(dart/change_detect): Add type to ChangeDetector context#2357
Merged
kegluneq merged 1 commit intoangular:masterfrom Jun 5, 2015
Merged
feat(dart/change_detect): Add type to ChangeDetector context#2357kegluneq merged 1 commit intoangular:masterfrom
kegluneq merged 1 commit intoangular:masterfrom
Conversation
Author
|
cc @yjbanov , this adds type to the pre-generated change detectors without removing |
kegluneq
force-pushed
the
cd_typed_context
branch
from
04547d7 to
bdcfdc7
Compare
Contributor
|
This is good, but you probably want to type all the directive fields too. |
vsavkin
added
pr_state: LGTM
action: merge
Author
|
One at a time, one at a time. Thanks for the review. |
Add a type for the `context` field in Dart's pre-generated change detectors. This requires slight changes to set the dehydrated value of `context` to `null` rather than `ChangeDetectionUtil.uninitialized()`, which was its former dehydrated state. Mirror these chagnes as closely as possible in the `ChangeDetectionJITGenerator` to allow easier maintenance. Closes angular#2070
kegluneq
force-pushed
the
cd_typed_context
branch
from
bdcfdc7 to
5298055
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a type for the
contextfield in Dart's pre-generated changedetectors. This requires slight changes to set the dehydrated value of
contexttonullrather thanChangeDetectionUtil.uninitialized(),which was its former dehydrated state.
Mirror these chagnes as closely as possible in the
ChangeDetectionJITGeneratorto allow easier maintenance.Closes #2070