X Tutup
Skip to content

chore(benchpress): add ff extension test to ci#2229

Closed
hankduan wants to merge 1 commit intoangular:masterfrom
hankduan:master
Closed

chore(benchpress): add ff extension test to ci#2229
hankduan wants to merge 1 commit intoangular:masterfrom
hankduan:master

Conversation

@hankduan
Copy link
Copy Markdown
Contributor

No description provided.

@tbosch tbosch added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Jun 1, 2015
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jun 1, 2015

Please remove custom selenium url
Please use a local url (e.g. index.html form hello_world example) instead of an external site.

@tbosch tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 1, 2015
@tbosch tbosch self-assigned this Jun 1, 2015
@tbosch tbosch removed the action: merge The PR is ready for merge by the caretaker label Jun 1, 2015
@hankduan hankduan force-pushed the master branch 5 times, most recently from 89cbab7 to b6aaa65 Compare June 2, 2015 06:58
@hankduan
Copy link
Copy Markdown
Contributor Author

hankduan commented Jun 2, 2015

hold off on merging this for a bit. Experimenting and changing code. Still trying to figure out why it's failing on CI and not on my local machine

@hankduan hankduan force-pushed the master branch 16 times, most recently from 8ac7bca to f7b38c9 Compare June 2, 2015 21:01
@hankduan hankduan force-pushed the master branch 2 times, most recently from db739b6 to 7c589a2 Compare June 2, 2015 21:38
@hankduan
Copy link
Copy Markdown
Contributor Author

hankduan commented Jun 2, 2015

dependent on: #2295

@hankduan
Copy link
Copy Markdown
Contributor Author

hankduan commented Jun 2, 2015

Should be good to go now.

@tbosch tbosch closed this in 5fa54a9 Jun 2, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup