chore(material): migrate most components to TypeScript.#2160
chore(material): migrate most components to TypeScript.#2160jelbourn wants to merge 1 commit intoangular:masterfrom
Conversation
There was a problem hiding this comment.
move the init value to the declaration ?
There was a problem hiding this comment.
I would rather make minimal changes in this PR to get things working and worry about idiomatic TS later.
There was a problem hiding this comment.
makes sense. I was also asking to know if we have defined a best practice for those.
There was a problem hiding this comment.
I don't think we've really talked about it yet. Would be a good thing to do soon.
|
A few questions that I also had when converting to TS, do we have guidelines on:
|
|
Oh... LGTM (OT why do material use a different clang-format style ?) |
|
@vicb the components will eventually be their own library / repo, and I hate the single-lining of functions and blocks. |
|
Closed via 0f3a8f3 |
There was a problem hiding this comment.
I prefer these as well. Maybe we should consider applying to all of Angular. The delta would be pretty big but maybe worth it? @mprobst ?
There was a problem hiding this comment.
I'm large apathetic to this. I generally like anything that saves vertical
space (in particular for object literals, and there in particular in
named-arguments style calls). But I don't feel too strongly about it, I
just want automated formatting that works well.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
All components migrated to TypeScript except for the dialog, which is blocked on #2127, and Tabs which are pending in #1977.
/cc @mprobst @alexeagle