feat(material): add prototype tabs component.#1977
feat(material): add prototype tabs component.#1977jelbourn wants to merge 1 commit intoangular:masterfrom
Conversation
There was a problem hiding this comment.
What if the removed tab was selected
There was a problem hiding this comment.
Changed to do something more sensible.
|
Abstract |
There was a problem hiding this comment.
add a todo for the failure modes:
- md-tab without label
- md-tab with md-tab-label but no md-tab-content
Since this is a WIP, doesn't need to be handled in this PR.
|
Converted to TS and added interface. All other comments addressed. Waiting for fix in ts2dart for interfaces to move forward. |
|
Did you try @implements annotation from lang? It might already work. |
|
Martin says the fix for ts2dart is very simple so I'm going to wait for that. |
|
Blocked on dart-archive/ts2dart#173 |
|
@jelbourn dart-archive/ts2dart#173 has been closed. Are you still blocked? |
|
Was waiting on @mprobst to do a ts2dart release + version bump, I'll check on this tomorrow. |
|
The bump has happened. |
|
@jelbourn you should be good to go! |
vsavkin
added
action: cleanup
|
Now blocked on #2627 |
|
@jelbourn What is the status here? Render services are ready to go... |
|
I've been working on other things since #2627 was fixed. I'll try to fix this up and get it submitted this week. |
|
Cleaning up PRs. This one has not been touched for a while. Please create new PR once ready. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
7 participants
Screenshot:
This is very early and doesn't do any of the fancy animation or styling stuff.
FYI @IgorMinar if you're curious how it came out after our brief paring.