feat(diffing-broccoli-plugin): use optional fast-path for initial builds#1963
feat(diffing-broccoli-plugin): use optional fast-path for initial builds#1963caitp wants to merge 2 commits intoangular:masterfrom
Conversation
|
Adding tests for the diffing plugin wrapper is problematic without support for class expressions and non-global class declarations (microsoft/TypeScript#497) |
Previously, tree-differ would not correctly handle symlinks to deleted files, resulting in an ENOENT errno being tossed by libuv. This change fixes this to ensure that symlinks are safely handled, performantly.
9d2cdd1 to
88ec418
Compare
… builds Enable plugins to use a fast path for the initial build, which does not require calculating a diff. Useful for plugins like Funnel or MergeTrees.
|
I don't think that we can do it like this because of several reasons:
Given this, it doesn't seem very useful to have plugins implement this special api. What might be useful, is to pass "firstBuild" info into the rebuild function. Take a look at #1906. I'm trying to implement the same thing there, but rather than changing what diffing plugins look like, I'm keeping track of whether a rebuild is first or not within the typescript plugin. |
|
it seems that the tree-diffing commit from the PR was already merged, but now that all input trees are stable (#2051) we don't actually need this because broken symlinks indicate a bug in a plugin or build system. the second commit is not needed, so I'm going to close this PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Enable plugins to use a fast path for the initial build, which does not
require calculating a diff. Useful for plugins like Funnel or MergeTrees.
Blocked on #1961