fix(tree-differ): treat symlinks to deleted paths as removals#1961
Closed
caitp wants to merge 1 commit intoangular:masterfrom
Closed
fix(tree-differ): treat symlinks to deleted paths as removals#1961caitp wants to merge 1 commit intoangular:masterfrom
caitp wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
|
This is sort of a blocker for #1814 as Funnel can use a symlink for performance. Another option is to have the fork always copy, but this seems slower |
caitp
force-pushed
the
tree-differ-symlinks
branch
2 times, most recently
from
240f90d to
f7382be
Compare
Previously, tree-differ would not correctly handle symlinks to deleted files, resulting in an ENOENT errno being tossed by libuv. This change fixes this to ensure that symlinks are safely handled, performantly.
caitp
force-pushed
the
tree-differ-symlinks
branch
from
f7382be to
88ec418
Compare
Contributor
|
lgtm |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, tree-differ would not correctly handle symlinks to deleted files, resulting in
an ENOENT errno being tossed by libuv.
This change fixes this to ensure that symlinks are safely handled, performantly.