-
Notifications
You must be signed in to change notification settings - Fork 27.2k
Description
I'm putting together some developer notes and the following came up.
Gulp target test.unit.js makes use of Chrome Canary
// karma-js.conf.js
browsers: ['ChromeCanary']Understandably, test.unit.dart and test.unit.dart/ci use Dartium
// karma-dart.conf.js
browsers: ['DartiumWithWebPlatform'],So far so good.
The surprise is that gulp target test.unit.js/ci launches Dartium both from the command line and under Travis: e.g. here is an excerpt from the Travis angular build 2000.1 (around line 671):
[00:43:02] Using gulpfile ~/build/angular/angular/gulpfile.js
[00:43:02] Starting 'test.unit.js/ci'...
INFO [karma]: Karma v0.12.31 server started at http://localhost:9876/
INFO [launcher]: Starting browser DartiumAs a developer, if I run tests from the command line I'd want to ensure that I'm using the same browser as CI under Travis. There is an inconsistency in the use of browsers. Is this really what we want? If not, which way do you want the inconsistency to be fixed? I.e.,
(a) Use Dartium across the board (for all Dart and JS tests).
(b) Use Chrome Canary (or just Chrome) for JS tests.
I can make the fix (if one is needed), I just need someone from the Angular core team to indicate which option is preferable.