feat(compiler): Resolvers now use DI to create reflector#7762
Closed
chuckjaz wants to merge 1 commit intoangular:masterfrom
Closed
feat(compiler): Resolvers now use DI to create reflector#7762chuckjaz wants to merge 1 commit intoangular:masterfrom
chuckjaz wants to merge 1 commit intoangular:masterfrom
Conversation
chuckjaz
force-pushed
the
resolver-parameter
branch
from
824c3a9 to
38458d2
Compare
Contributor
|
Looks good. Maybe rename the commit into |
Contributor
|
Do you also want to change |
tbosch
added
pr_state: LGTM
action: cleanup
Contributor
Author
|
Turns out that |
chuckjaz
force-pushed
the
resolver-parameter
branch
2 times, most recently
from
a41dee7 to
b2f8803
Compare
chuckjaz
changed the title
chuckjaz
force-pushed
the
resolver-parameter
branch
from
b2f8803 to
894b984
Compare
chuckjaz
added
action: merge
Also introduced ReflectorReader when only read-only access to the reflector is needed.
chuckjaz
force-pushed
the
resolver-parameter
branch
from
894b984 to
1030947
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reflector that is used by the metadata resolvers is now a parameter that can be initialized by DI.
The metadata resolvers unconditionally use
reflectorfrom'angular2/core'.The metadata resolvers now use the
reflectorthat passed in as a constructor parater.DirectiveResolver,PipeResolverandViewResolvernow take the reflector they will use as a parameter. Code that constructs instances manually now need to provide theReflectorinstance they wish to use. Ifreflectorfrom'angular/core'is passed as the parameters, they will behave identically to previous behavior.Also introduced ReflectorReader when only read-only access to the reflector is needed. The metadata resolvers only use the methods from ReflectorReader and the type the request from DI. The platform injector was updated to request the existing Reflector instance by default for ReflectorReader.