Closed
Conversation
|
Issue moved to angular/a #9 via ZenHub.io |
btford
force-pushed
the
fix-core-error-messages
branch
3 times, most recently
from
463cd42 to
9f9909d
Compare
btford
added
the
action: review
Contributor
There was a problem hiding this comment.
I am wondering if instead of did you mean to bind we could say NgFor only supports binding to Iterables such as Arrays.?
mhevery
added
pr_state: LGTM
action: cleanup
Before, you'd get an error like: ``` EXCEPTION: Cannot find a differ supporting object ‘[object Object]’ in [users in UsersCmp@2:14] ``` Now, you get: ``` EXCEPTION: Cannot find a differ supporting object ‘[object Object]’ of type 'Object'. Did you mean to bind ngFor to an Array? in [users in UsersCmp@2:14] ```
Part of angular#7481 (effort to improve error messages)
btford
force-pushed
the
fix-core-error-messages
branch
from
9f9909d to
9dfa1cc
Compare
Contributor
Author
|
Fixed. |
btford
added
action: merge
|
User @kara does not have PR merging privileges. |
|
Merging PR #7559 on behalf of @kara to branch presubmit-kara-pr-7559. |
|
Merging PR #7559 on behalf of @kara to branch presubmit-kara-pr-7559. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP branch related to: #7481