X Tutup
Skip to content

Route.params are appended as matrix AND query to Location in Router #7314

@AlexBachmann

Description

@AlexBachmann

So, in the RootRouter.commit method, the RouteParams are appended twice to the URL, causing an URL like this

http://host.com/path?state=3&code=4
to be transformed to an url like this
http://host.com/path;state=3;code=4?state=3&code=4

by angular.

This is not very pretty, and can cause problems, especially if you allow forward slashes in url query parameters, as I propose in #7312.

So the question is, how to fix this issue? I would propose to only append RouteParams by query parameters and drop matrix variables. However, I don't know if that is as easily done than said.

If matrix parameters need to be supported, then I would suggest, that they are supported by some sort of strategy pattern, so we can prevent duplication of parameters in the URL.

Does anybody have an opinion on this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      X Tutup