feat(plural): add plural and select pipes#7268
Closed
kara wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Name suggestion I18nPluralPipe ???
828c59f to
86e580f
Compare
Contributor
Author
|
@mhevery I think I addressed all the comments. Let me know if there's anything else I should change! |
427cebd to
ccc89d5
Compare
Contributor
Author
There was a problem hiding this comment.
(we discussed and decided to leave as is)
140b482 to
8f2b73c
Compare
bcd0290 to
de34553
Compare
|
Merging PR #7268 on behalf of @vsavkin to branch presubmit-vsavkin-pr-7268. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mhevery @vsavkin Review?
i18n plural pipe
Maps a value to a string that pluralizes the value properly.
Usage
expression | i18nPlural:mapping
where
expressionis a number andmappingis an object that indicates the proper text forwhen the
expressionevaluates to 0, 1, or some other number. You can interpolate the actualvalue into the text using the
#sign.Example
i18n select pipe
Generic selector that displays the string that matches the current value.
Usage
expression | i18nSelect:mapping
where
mappingis an object that indicates the text that should be displayed for different values of the providedexpression.Example