fix(router): handle unrecognized instructions#7203
Closed
tiziano88 wants to merge 1 commit intoangular:masterfrom
tiziano88:master
Closed
fix(router): handle unrecognized instructions#7203tiziano88 wants to merge 1 commit intoangular:masterfrom tiziano88:master
tiziano88 wants to merge 1 commit intoangular:masterfrom
tiziano88:master
Conversation
This is currently throwing a null error when the instruction is not recognized by the router, and AFAICT there is no way to catch that.
Author
|
Apparently this change is making this test fail because it changes how default routes are handled. It would be great if someone from the Angular team could comment on what the desired behaviour should be in this case. |
Contributor
|
@tiziano88 can you please provide
I am sure that we should not silently fail if a route is not found. |
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Mar 9, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7349
This is currently throwing a null error when the instruction is not
recognized by the router, and AFAICT there is no way to catch that.