X Tutup
Skip to content

fix(router): handle unrecognized instructions#7203

Closed
tiziano88 wants to merge 1 commit intoangular:masterfrom
tiziano88:master
Closed

fix(router): handle unrecognized instructions#7203
tiziano88 wants to merge 1 commit intoangular:masterfrom
tiziano88:master

Conversation

@tiziano88
Copy link
Copy Markdown

Fixes: #7349

This is currently throwing a null error when the instruction is not
recognized by the router, and AFAICT there is no way to catch that.

This is currently throwing a null error when the instruction is not
recognized by the router, and AFAICT there is no way to catch that.
@tiziano88
Copy link
Copy Markdown
Author

Apparently this change is making this test fail because it changes how default routes are handled. It would be great if someone from the Angular team could comment on what the desired behaviour should be in this case.

@petebacondarwin
Copy link
Copy Markdown
Contributor

@tiziano88 can you please provide

  • a more explicit context for the error (perhaps a code example?)
  • a unit test that demonstrates the bug being fixed

I am sure that we should not silently fail if a route is not found.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Router): Stack trace on unrecognized routes

4 participants

X Tutup