X Tutup
Skip to content

feat(core): add more debug APIs to inspect the application form a bro…#7161

Closed
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:debug-apis
Closed

feat(core): add more debug APIs to inspect the application form a bro…#7161
tbosch wants to merge 1 commit intoangular:masterfrom
tbosch:debug-apis

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented Feb 18, 2016

…wser

Adds window.getAllAngularRootElements()
Adds ng.probe.coreTokens.ApplicationRef
Adds ng.probe.coreTokens.Ngzone

Closes #7045

@juliemr juliemr self-assigned this Feb 18, 2016
@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 18, 2016
@tbosch tbosch mentioned this pull request Feb 18, 2016
Closed
@juliemr
Copy link
Copy Markdown
Member

juliemr commented Feb 19, 2016

The public API change is causing Travis failures.

juliemr
juliemr reviewed Feb 19, 2016
View reviewed changes
modules/angular2/src/platform/dom/debug/ng_probe.ts Outdated
Copy link
Copy Markdown
Member

@juliemr juliemr Feb 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to avoid a function which also has properties. I don't know if Dart deals with that well? What about just ng.coreTokens?

Copy link
Copy Markdown
Member

@juliemr juliemr Feb 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe ng.debug.coreTokens?

@juliemr juliemr added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 19, 2016
@juliemr juliemr assigned tbosch and unassigned juliemr Feb 19, 2016
@zoechi zoechi mentioned this pull request Feb 19, 2016
Closed
@lacolaco
Copy link
Copy Markdown
Contributor

lacolaco commented Feb 19, 2016

@tbosch Excuse me. What's getAllRootElements() return? I'm happy if the function can return all components attached in app.

@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Feb 19, 2016

@laco0416 this will return all elements where an angular application is bootstraped. I.e. all elements of root components.

@tbosch
feat(core): add more debug APIs to inspect the application form a bro…
ea15bb3 
…wser

Adds `window.getAllAngularRootElements()`
Adds `ng.coreTokens.ApplicationRef`
Adds `ng.coreTokens.Ngzone`

Closes angular#7045
@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Feb 19, 2016

@juliemr PTAL

@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Feb 19, 2016

Get in person LGTM from @juliemr

@tbosch tbosch added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 19, 2016
@lacolaco
Copy link
Copy Markdown
Contributor

lacolaco commented Feb 19, 2016

@tbosch thank you. but sorry, I didn't know what root components means. does it equal to each components?

@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Feb 19, 2016

Only the components that are being bootstrapped.
Components inside of bootstrapped components won't be contained in this array.

@lacolaco
Copy link
Copy Markdown
Contributor

lacolaco commented Feb 19, 2016

@tbosch Thank you very much! I'll try looking for other way.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 1, 2016

Merging PR #7161 on behalf of @vsavkin to branch presubmit-vsavkin-pr-7161.

@mhevery mhevery closed this in b5e6319 Mar 1, 2016
@tbosch tbosch deleted the debug-apis branch March 15, 2016 15:06
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@tbosch tbosch

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose application tokens via ngProbe for chrome extensions, ...

6 participants

@tbosch @juliemr @lacolaco @mary-poppins @vsavkin @googlebot
X Tutup