fix(router): fix url path for star segment in path recognizer#6976
fix(router): fix url path for star segment in path recognizer#6976btford wants to merge 1 commit intoangular:masterfrom
Conversation
Url path of star segments should equal the original path. If you register the route `/app/*location` and invoke a url like `/app/foo/bar` the PathRecognizer should return a url path equal to the invoked url. Before this patch, everything after `foo` was ignored, which resulted in a redirect to `/app/foo` which was probably not intended (at least in the angular 1.5 component router).
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
btford
added
pr_state: LGTM
action: merge
|
Merging PR #6976 on behalf of @btford to branch presubmit-btford-pr-6976. |
1 similar comment
|
Merging PR #6976 on behalf of @btford to branch presubmit-btford-pr-6976. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Supersedes #6514
Url path of star segments should equal the original path.
If you register the route
/app/*locationand invoke a url like/app/foo/barthe PathRecognizer should return a url path equal to the invoked url.
Before this patch, everything after
foowas ignored, which resulted in aredirect to
/app/foowhich was probably not intended (at least in the angular1.5 component router).