fix(ngFor): update view values manually with track by#6923
Closed
kara wants to merge 1 commit intoangular:masterfrom
Closed
fix(ngFor): update view values manually with track by#6923kara wants to merge 1 commit intoangular:masterfrom
kara wants to merge 1 commit intoangular:masterfrom
Conversation
kara
added
action: review
kara
added
action: merge
Contributor
|
Reviewed with Kara in person, will keep track of identity changes as a separate list. |
kara
force-pushed
the
trackbyfix
branch
2 times, most recently
from
1200d89 to
e4f5203
Compare
kara
added
action: review
Contributor
|
Very nice! LGTM |
mhevery
added
action: merge
Contributor
|
Assigning to @IgorMinar for merge |
|
Merging PR #6923 on behalf of @btford to branch presubmit-btford-pr-6923. |
Contributor
|
👏 good work everyone |
Member
|
I assume this fixes #6907 ? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vsavkin @mhevery Review?
Closes #6907