X Tutup
Skip to content

chore(core): mute mode printing in console in prod mode#6873

Closed
samjulien wants to merge 1 commit intoangular:masterfrom
samjulien:mute-mode-fix
Closed

chore(core): mute mode printing in console in prod mode#6873
samjulien wants to merge 1 commit intoangular:masterfrom
samjulien:mute-mode-fix

Conversation

@samjulien
Copy link
Copy Markdown
Contributor

Trying this again after botching the rebase of the last one. Issue #6540. Talked with @robwormald briefly and he suggested simply muting that logging if not in dev mode. cc @vsavkin

@jeffbcross
Copy link
Copy Markdown
Contributor

@samjulien thanks for the PR, Travis is just failing because of a formatting error. Can you run these commands locally to format your changes, amend your commit, and force push your branch?

node_modules/clang-format/index.js -i -style="file" /home/travis/build/angular/angular/modules/angular2/src/core/application_ref.ts
git commit -a --amend
git push origin mute-mode-fix -f

@jeffbcross jeffbcross added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 8, 2016
@samjulien
Copy link
Copy Markdown
Contributor Author

Thank you for your help, @jeffbcross -- looks like all systems are go!

@jeffbcross jeffbcross added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 9, 2016
@jeffbcross
Copy link
Copy Markdown
Contributor

@samjulien thanks!

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup