chore(core): mute mode printing in console in prod mode#6873
Closed
samjulien wants to merge 1 commit intoangular:masterfrom
samjulien:mute-mode-fix
Closed
chore(core): mute mode printing in console in prod mode#6873samjulien wants to merge 1 commit intoangular:masterfrom samjulien:mute-mode-fix
samjulien wants to merge 1 commit intoangular:masterfrom
samjulien:mute-mode-fix
Conversation
Contributor
|
@samjulien thanks for the PR, Travis is just failing because of a formatting error. Can you run these commands locally to format your changes, amend your commit, and force push your branch? |
Contributor
Author
|
Thank you for your help, @jeffbcross -- looks like all systems are go! |
Contributor
|
@samjulien thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying this again after botching the rebase of the last one. Issue #6540. Talked with @robwormald briefly and he suggested simply muting that logging if not in dev mode. cc @vsavkin