X Tutup
Skip to content

fix(bundles): testing bundle should include browser platform#6626

Closed
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:testing_bundle
Closed

fix(bundles): testing bundle should include browser platform#6626
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:testing_bundle

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Jan 22, 2016

No description provided.

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 22, 2016
@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Jan 22, 2016

cc @pkozlowski-opensource
Not sure if any other stuff is missing from the bundles based on recent work?

@juliemr
Copy link
Copy Markdown
Member

juliemr commented Jan 22, 2016

I think that this includes everything that's changed from the testing perspective. LGTM.

@juliemr juliemr added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 22, 2016
@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Jan 22, 2016

I confirmed with this fix that we can finally execute tests in google3.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Jan 22, 2016
@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Jan 22, 2016

got the ok to merge from caretaker.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 22, 2016

Merging PR #6626 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6626.

@mhevery mhevery closed this in 4a41442 Jan 22, 2016
@usernamealreadyis
Copy link
Copy Markdown

usernamealreadyis commented Jan 24, 2016

====****=====
master closed this in 4a41442 2 days ago just do this pathetic
'master closed': need help cause so pathetic and 'open commit:' commit 4a41442

=====++--=====
master closed its mean = master closet
=====++--=====

====****=====

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexeagle @juliemr @mary-poppins @usernamealreadyis @googlebot
X Tutup