fix(testing): remove test zone for now and rely on returned promises#6601
Closed
juliemr wants to merge 1 commit intoangular:masterfrom
Closed
fix(testing): remove test zone for now and rely on returned promises#6601juliemr wants to merge 1 commit intoangular:masterfrom
juliemr wants to merge 1 commit intoangular:masterfrom
Conversation
Adds tests for public Dart and TS frameworks to make sure that components with templateUrl can be created by the TestComponentBuilder. Closes angular#6359
juliemr
added
area: testing
juliemr
added
the
action: review
Contributor
There was a problem hiding this comment.
this seems wrong, why should we be done() here? The promise may not have resolved yet.
Contributor
There was a problem hiding this comment.
never mind, not used to the github collapsed lines view...
alexeagle
added
pr_state: LGTM
and removed
action: review
Member
Author
|
Thanks! |
|
Merging PR #6601 on behalf of @rkirov to branch presubmit-rkirov-pr-6601. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for public Dart and TS frameworks to make sure that
components with templateUrl can be created by the TestComponentBuilder.
Closes #6359