X Tutup
Skip to content

fix(upgrade): fix infinite $rootScope.$digest()#6386

Closed
andreialecu wants to merge 1 commit intoangular:masterfrom
andreialecu:patch-1
Closed

fix(upgrade): fix infinite $rootScope.$digest()#6386
andreialecu wants to merge 1 commit intoangular:masterfrom
andreialecu:patch-1

Conversation

@andreialecu
Copy link
Copy Markdown
Contributor

Fixes #6385

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@andreialecu
Copy link
Copy Markdown
Contributor Author

@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 1, 2016
@andreialecu
Copy link
Copy Markdown
Contributor Author

Bump.

There were 3 beta releases since posting this.

This bug makes it impossible to upgrade anything but the most trivial app since a lot of angular1 components use timers... I need to maintain my own fork to be able to use angular2 at all.

Paging @vsavkin @pkozlowski-opensource @tbosch @mhevery

@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 7, 2016
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Feb 7, 2016

Scheduled for merging.

@andreialecu
Copy link
Copy Markdown
Contributor Author

@mhevery: Awesome, maybe have a look at my other PR as well which is also blocking: #6460

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(upgrade): infinite digests with setTimeout (repro inside)

4 participants

X Tutup