X Tutup
Skip to content

fix(router): fix incorrect url param value coercion of 1 to true#6286

Closed
bkyarger wants to merge 1 commit intoangular:masterfrom
bkyarger:route-param-incorrect-coercion
Closed

fix(router): fix incorrect url param value coercion of 1 to true#6286
bkyarger wants to merge 1 commit intoangular:masterfrom
bkyarger:route-param-incorrect-coercion

Conversation

@bkyarger
Copy link
Copy Markdown
Contributor

@bkyarger bkyarger commented Jan 6, 2016

seriliazeParams is coercing a value of 1 to true, which causes the value to be completey dropped.
Change the test from double equals to triple equals to prevent this from happening.

Closes #5346

@bkyarger bkyarger force-pushed the route-param-incorrect-coercion branch from c2120c9 to 1167a07 Compare January 6, 2016 05:57
@bkyarger bkyarger mentioned this pull request Jan 12, 2016
Closed
@bkyarger
fix(router): fix incorrect url param value coercion of 1 to true
7483a52 
seriliazeParams is coercing a value of 1 to true, which causes the value to be completey dropped.
Change the test from double equals to triple equals to prevent this from happening.

Closes angular#5346
@bkyarger bkyarger force-pushed the route-param-incorrect-coercion branch from 1167a07 to 7483a52 Compare January 14, 2016 04:17
@bkyarger bkyarger closed this Jan 14, 2016
@bkyarger bkyarger reopened this Jan 14, 2016
@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2016
@petebacondarwin petebacondarwin self-assigned this Jan 29, 2016
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 31, 2016

Merging PR #6286 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6286.

@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Jan 31, 2016

Thanks @alexeagle

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 1, 2016

User @petebacondarwin does not have PR merging privileges.

@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Feb 1, 2016

Agh! The original merge attempt by @alexeagle failed because the PR needed a rebase.
I rebased and it now passes on Travis but it doesn't seem to be merging (despite being in a presubmit branch).
And I don't have privileges to add the zomg_admin: do merge label.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 1, 2016

Merging PR #6286 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6286.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 3, 2016

Merging PR #6286 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6286.

@mhevery mhevery closed this in 995a9e0 Feb 3, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@petebacondarwin petebacondarwin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes type: bug/fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(router): incorrect type coercion of value 1 in RouteParam

6 participants

@bkyarger @mary-poppins @petebacondarwin @alexeagle @robwormald @googlebot
X Tutup