Typings cleanup by alexeagle · Pull Request #6267 · angular/angular

alexeagle · 2016-01-05T14:40:04Z

We had our own fork due to some custom typings, but these have been pushed upstream.

alexeagle · 2016-01-10T23:24:16Z

Something is fishy. In angular's fork we have "zone" (https://github.com/angular/DefinitelyTyped/blob/master/zone/zone.d.ts). The one on DefinitelyTyped has "zone.js" (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/zone.js/zone.js.d.ts#L6)

This PR should have failed on Travis because the zone typings are missing.
the log has under npm install:

>> written 7 files:
    - angular-protractor/angular-protractor.d.ts
    - es6-shim/es6-shim.d.ts
    - hammerjs/hammerjs.d.ts
    - jasmine/jasmine.d.ts
    - node/node.d.ts
    - selenium-webdriver/selenium-webdriver.d.ts
    - zone/zone.d.ts

Where did it find zone.d.ts?? Did it come from the Travis cache even though this PR should bust the cache? Fishy.

alexeagle · 2016-01-10T23:27:55Z

Hmm, I think it's because we give a SHA, and that can be resolved against a repo that doesn't have that in the tree anywhere: this works
DefinitelyTyped/DefinitelyTyped@31e7317
even though that change only appeared on the angular fork. So maybe it's legit that Travis passed.
I'll update the PR though'

alexeagle · 2016-01-27T19:50:20Z

cc @vikerman

rkirov · 2016-01-29T00:16:50Z

modules/angular1_router/tsd.json

no more forks!

rkirov · 2016-01-29T00:25:55Z

looks good, make lint pass

btford · 2016-02-01T23:23:47Z

Is this ready to merge?

alexeagle · 2016-02-01T23:29:16Z

not ready to merge yet

The upstream Jasmine typings don't define a type for the global object with Jasmine methods polluting it, so just use any. Also zone.js has a different name upstream.

alexeagle · 2016-02-04T21:04:23Z

Reviewed in person with @mhevery

alexeagle · 2016-02-04T21:07:31Z

cc @blakeembrey who helped with the design for this - thank you!

This resolves Duplicate Identifier issues seen by many users, at the expense of more typings installation required in some cases. Removes the quickstart hack of placing all needed dependencies typings files in our distribution. Removes dependencies on nodejs from angular2/core. Fixes angular#5973 Fixes angular#5807 Fixes angular#6266 Angular now depends on es6-promise and es6-collections (and a handful of manual typings) rather than all of es6-shim. Fixes angular#5242 We previously had an undocumented breaking change, this is now documented in this commit. Fixes angular#6817 BREAKING CHANGE: Transitive typings are no longer included in the distribution. You may need to install typings in your project using http://github.com/typings/typings Users now must rely on getting typings from: - one of the peerDependencies, such as rxjs, which exposes typings via the moduleResolution=node mechanism. (see https://github.com/Microsoft/TypeScript/wiki/Typings-for-npm-packages) This happens automatically. - Using --target ES5 now requires manual installation of es6-promise and es6-collections typings. - Using some angular APIs may introduce a dependency on eg. nodejs or jasmine, and those typings need manual installation as well.

mary-poppins · 2016-02-04T22:36:23Z

Merging PR #6267 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-6267.

angular-automatic-lock-bot · 2019-09-07T23:21:34Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jan 5, 2016

alexeagle assigned alexeagle and IgorMinar and unassigned alexeagle Jan 9, 2016

alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 9, 2016

alexeagle force-pushed the unfork_dt branch from 870f518 to 46a3c69 Compare January 10, 2016 23:35

alexeagle mentioned this pull request Jan 10, 2016

Cannot target ES6 in Typescript (possible regression) #5973

Closed

alexeagle force-pushed the unfork_dt branch 2 times, most recently from 883c507 to 621e774 Compare January 11, 2016 23:29

alexeagle mentioned this pull request Jan 22, 2016

feat(ambient): zone typings/registry#51

Merged

alexeagle force-pushed the unfork_dt branch 5 times, most recently from 45626ee to 28a31f4 Compare January 28, 2016 19:22

alexeagle assigned rkirov and unassigned IgorMinar Jan 28, 2016

alexeagle force-pushed the unfork_dt branch from 28a31f4 to 8930405 Compare January 28, 2016 23:46

rkirov reviewed Jan 29, 2016
View reviewed changes

modules/angular1_router/tsd.json

Copy link
Copy Markdown

Contributor

rkirov Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more forks!

rkirov added the pr_state: LGTM label Jan 29, 2016

alexeagle force-pushed the unfork_dt branch from 8930405 to 0cc9191 Compare January 29, 2016 00:44

alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 29, 2016

alexeagle force-pushed the unfork_dt branch from 5a5843c to 4896db3 Compare January 31, 2016 03:03

alexeagle removed the action: merge The PR is ready for merge by the caretaker label Jan 31, 2016

alexeagle force-pushed the unfork_dt branch 3 times, most recently from 5c8ae97 to 77ad163 Compare February 1, 2016 20:33

alexeagle added 2 commits February 4, 2016 09:52

chore(deps): update ts2dart and zone.js

f8821dd

chore(typings): use mainline DefinitelyTyped repo rather than a fork.

decf115

The upstream Jasmine typings don't define a type for the global object with Jasmine methods polluting it, so just use any. Also zone.js has a different name upstream.

alexeagle force-pushed the unfork_dt branch from 77ad163 to be5ff79 Compare February 4, 2016 19:11

alexeagle mentioned this pull request Feb 4, 2016

Jasmine constructs aren't available with beta 2 anymore #6817

Closed

alexeagle force-pushed the unfork_dt branch 4 times, most recently from 3013149 to 03c0314 Compare February 4, 2016 21:03

alexeagle removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 4, 2016

alexeagle force-pushed the unfork_dt branch from 03c0314 to 4509820 Compare February 4, 2016 21:20

alexeagle force-pushed the unfork_dt branch from 4509820 to 7f85092 Compare February 4, 2016 21:35

alexeagle added the action: merge The PR is ready for merge by the caretaker label Feb 4, 2016

alexeagle assigned IgorMinar and unassigned rkirov Feb 4, 2016

IgorMinar added the zomg_admin: do merge label Feb 4, 2016

mary-poppins removed the zomg_admin: do merge label Feb 4, 2016

mhevery closed this in 2a70f4e Feb 4, 2016

jesperronn mentioned this pull request Feb 11, 2016

(FAILING) Beta 5 update mgechev/angular-seed#462

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Typings cleanup#6267

Typings cleanup#6267
alexeagle wants to merge 3 commits intoangular:masterfrom
alexeagle:unfork_dt

alexeagle commented Jan 5, 2016

Uh oh!

alexeagle commented Jan 10, 2016

Uh oh!

alexeagle commented Jan 10, 2016

Uh oh!

alexeagle commented Jan 27, 2016

Uh oh!

rkirov Jan 29, 2016

Uh oh!

rkirov commented Jan 29, 2016

Uh oh!

btford commented Feb 1, 2016

Uh oh!

alexeagle commented Feb 1, 2016

Uh oh!

alexeagle commented Feb 4, 2016

Uh oh!

alexeagle commented Feb 4, 2016

Uh oh!

mary-poppins commented Feb 4, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

alexeagle commented Jan 5, 2016

Uh oh!

alexeagle commented Jan 10, 2016

Uh oh!

alexeagle commented Jan 10, 2016

Uh oh!

alexeagle commented Jan 27, 2016

Uh oh!

rkirov Jan 29, 2016

Choose a reason for hiding this comment

Uh oh!

rkirov commented Jan 29, 2016

Uh oh!

btford commented Feb 1, 2016

Uh oh!

alexeagle commented Feb 1, 2016

Uh oh!

alexeagle commented Feb 4, 2016

Uh oh!

alexeagle commented Feb 4, 2016

Uh oh!

mary-poppins commented Feb 4, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants