fix(router): correctly sort route matches with children by specificity#6011
Closed
btford wants to merge 1 commit intoangular:masterfrom
Closed
fix(router): correctly sort route matches with children by specificity#6011btford wants to merge 1 commit intoangular:masterfrom
btford wants to merge 1 commit intoangular:masterfrom
Conversation
btford
force-pushed
the
fix-router-child-specificity
branch
from
0a9036f to
9a37d25
Compare
btford
force-pushed
the
fix-router-child-specificity
branch
from
9a37d25 to
74b2d6d
Compare
This changes the way we calculate specificity. Instead of using a number, we use a string, so that combining specificity across parent-child instructions becomes a matter of concatenating them Fixes angular#5848
btford
force-pushed
the
fix-router-child-specificity
branch
from
74b2d6d to
b3a5a39
Compare
|
Merging PR #6011 on behalf of @mprobst to branch presubmit-mprobst-pr-6011. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the way we calculate specificity. Instead of using a number, we use a string, so that combining specificity across parent-child instructions becomes a matter of concatenating them.
Fixes #5848