fix(router): preserve specificity for redirects#5933
fix(router): preserve specificity for redirects#5933btford wants to merge 1 commit intoangular:masterfrom
Conversation
btford
added
pr_state: LGTM
action: merge
|
Got an in-person LGTM from @matsko |
|
Merging PR #5933 on behalf of @mprobst to branch presubmit-mprobst-pr-5933. |
|
presubmit job failed: |
|
Hm, let me rebase and try again. |
Previously when comparing which of multiple possible routes to choose in an ambiguous case, we looked at the specificity of the target of redirect matches rather than the original match. This meant that if a redirect used a whilecard, but redirected to a target that was a static path, we'd cound the static path's specificity instead of the wildcard. This change stores the specificity of the redirect on the RedirectInstruction.
btford
force-pushed
the
router-fix-redirect-speficificity
branch
from
77fee7a to
4e6c4a8
Compare
|
Looks like there was a merge conflict in master. Resolved the issue with this PR. @alexeagle can we try merging this again? |
|
You are the caretaker! On Mon, Dec 21, 2015 at 1:05 PM Brian Ford notifications@github.com wrote:
|
|
Merging PR #5933 on behalf of @alxhub to branch presubmit-alxhub-pr-5933. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
Previously when comparing which of multiple possible routes to choose in an ambiguous case, we looked at the specificity of the target of redirect matches rather than the original match. This meant that if a redirect used a wildcard, but redirected to a target that was a static path, we'd count the static path's specificity instead of the wildcard.
This change stores the specificity of the redirect on the
RedirectInstruction.