feat(router): support links with just auxiliary routes#5930
Closed
btford wants to merge 1 commit intoangular:masterfrom
Closed
feat(router): support links with just auxiliary routes#5930btford wants to merge 1 commit intoangular:masterfrom
btford wants to merge 1 commit intoangular:masterfrom
Conversation
btford
added
feature
btford
force-pushed
the
fix-router-aux-route-things
branch
from
9aaed6c to
1db585b
Compare
btford
force-pushed
the
fix-router-aux-route-things
branch
from
1db585b to
9fd6745
Compare
Contributor
Author
|
I followed @matsko home to get him to LGTM it in person and he did. 👹 |
btford
added
pr_state: LGTM
action: merge
|
User @mprobst does not have PR merging privileges. |
Contributor
|
@alexeagle I need that privilege, apparently. |
|
Merging PR #5930 on behalf of @mprobst to branch presubmit-mprobst-pr-5930. |
Contributor
Author
|
👏 thanks @mary-poppins and @mprobst |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support links like:
<a [routerLink]="['/', ['Modal']]">open modal</a>With no primary route part.