fix(bundles): don't use angular2/angular2 in config of System.registe…#5797
Closed
pkozlowski-opensource wants to merge 2 commits intoangular:masterfrom
Closed
Conversation
pkozlowski-opensource
force-pushed
the
no_angular2_in_sys_register_bundles_config
branch
from
71f9286 to
f7923c2
Compare
Closes angular#5815 BREAKING CHANGE: The following symbols are not exported from angular2/angular2 any more: `UrlResolver`, `AppRootUrl`, `getUrlScheme`, `DEFAULT_PACKAGE_URL_PROVIDER`. Use imports from `angular2/compiler` instead.
pkozlowski-opensource
force-pushed
the
no_angular2_in_sys_register_bundles_config
branch
from
f7923c2 to
1fed969
Compare
pkozlowski-opensource
added
the
action: review
This was referenced Dec 11, 2015
tbosch
added
pr_state: LGTM
and removed
action: review
tbosch
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r bundles
Related #5710
BREAKING CHANGE:
Few compiler symbols (
UrlResolver,AppRootUrl,getUrlScheme,DEFAULT_PACKAGE_URL_PROVIDER)that used to be part of the angular2.js bundle are not part of this bundle any more.