X Tutup
Skip to content

fix(changelog): fix ngFor on template#5785

Closed
tuurbo wants to merge 1 commit intoangular:masterfrom
tuurbo:patch-2
Closed

fix(changelog): fix ngFor on template#5785
tuurbo wants to merge 1 commit intoangular:masterfrom
tuurbo:patch-2

Conversation

@tuurbo
Copy link
Copy Markdown
Contributor

@tuurbo tuurbo commented Dec 10, 2015

No description provided.

@IgorMinar IgorMinar closed this in 3190c59 Dec 10, 2015
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Dec 10, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't there be quotes around items (in [ngForOf]=items) as well?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

On Thu, Dec 10, 2015 at 4:22 AM Günter Zöchbauer notifications@github.com
wrote:

In modules/angular2/docs/migration/kebab-case.md
#5785 (comment):

@@ -38,7 +38,7 @@ Notes:

  • <my-cmp (my-event)="action()"> should be changed to <my-cmp (myEvent)="action()">,
  • <my-cmp [(my-prop)]="prop"> should be changed to <my-cmp [(myProp)]="prop">,
  • <input #my-input> should be changed to <input #myInput>,
      • <template ng-for #my-item [ng-for-of]=items #my-index="index"> should be changed to <template ngFor="#my-item" [ngForOf]=items #myIndex="index">,
      • <template ng-for #my-item [ng-for-of]=items #my-index="index"> should be changed to <template ngFor #my-item [ngForOf]=items #myIndex="index">,

shouldn't there be quotes around items (in [ngForOf]=items) as well?


Reply to this email directly or view it on GitHub
https://github.com/angular/angular/pull/5785/files#r47219655.

@tuurbo tuurbo deleted the patch-2 branch December 10, 2015 21:08
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup