Benchpress: add receivedData + requestCount to PerflogMetric#5750
Benchpress: add receivedData + requestCount to PerflogMetric#5750ochafik wants to merge 1 commit intoangular:masterfrom
Conversation
|
Wow, I am impressed. This looks really great! |
tbosch
added
the
action: review
There was a problem hiding this comment.
Could you also add the category blink.user_timing to https://github.com/angular/angular/blob/master/protractor-shared.js#L41? Or is it automatically included via the categories v8,blink.console,devtools.timeline that we already have there?
There was a problem hiding this comment.
Seems to come for free through blink.console, actually.
|
Could you also add some docs about how to use this to https://github.com/angular/angular/blob/master/modules/benchpress/docs/index.md#smoothness-metrics? Similar to the smoothness-metrics? |
tbosch
added
pr_state: LGTM
action: cleanup
|
Please ping me directly when changes are done and Travis is green... |
ochafik
force-pushed
the
received-data-and-requests-sent-since-navigation-start
branch
from
ecb0e7b to
e906088
Compare
|
Sorry, I forgot: Could you use these features in https://github.com/angular/angular/blob/master/modules/playground/test/benchpress/webdriver_async.server.spec.dart, so we can can make sure they actually work? |
tbosch
added
action: merge
|
Decided not to add an e2e test as some of the trace info is not available in Chrome 39 (Dartium), but our CI only runs Dartium right now. |
|
Merging PR #5750 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5750. |
|
Thanks guys! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Hey @tbosch, here's a timid attempt to add these measures :-)