fix(TemplateParser): match element and attributes regardless the name…#5745
Closed
vicb wants to merge 2 commits intoangular:masterfrom
Closed
fix(TemplateParser): match element and attributes regardless the name…#5745vicb wants to merge 2 commits intoangular:masterfrom
vicb wants to merge 2 commits intoangular:masterfrom
Conversation
vicb
added
type: bug/fix
action: review
tbosch
added
pr_state: LGTM
and removed
action: review
Contributor
|
Any concern about how this will merge into g3? Does it affect downstream Dart users? |
Contributor
Author
|
There should be no pb |
|
Merging PR #5745 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5745. |
|
Merging PR #5745 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5745. |
Contributor
|
Can you rebase it on top of master and reapply the merge label? |
Contributor
Author
|
Merging PR #5745 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5745. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…space
relates to #5547