feat(bundles): add angular-testing UMD bundle#5734
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Closed
feat(bundles): add angular-testing UMD bundle#5734pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
Member
Author
|
@rkirov here is a PR for a testing UMD bundle. PTAL |
pkozlowski-opensource
added
the
action: review
Contributor
There was a problem hiding this comment.
Add a comment that everything until the last line is same as angular2.umd.js, in case someone makes a change in only one of them.
Contributor
|
LGTM, haven't had time to manually test it, but I don't want to block getting this in, so that someone else might give it a spin. |
pkozlowski-opensource
force-pushed
the
angular2_testing_umd
branch
from
001f676 to
d470b46
Compare
pkozlowski-opensource
added
pr_state: LGTM
action: merge
|
Merging PR #5734 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5734. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5581