fix(testing): remove Symbol dummy shim#5719
Closed
marclaval wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
marclaval
added
the
action: review
marclaval
force-pushed
the
cleanSymbol
branch
from
dbf9928 to
fb5f1d7
Compare
Contributor
|
lgtm. in the future please mention why it's ok to remove this. (in this case the issue was fixed in rxjs: ReactiveX/rxjs#640 so we no longer need the shim) |
IgorMinar
added
pr_state: LGTM
action: merge
Contributor
|
I think we have to wait for the upstream fix to land before CI will be green. |
|
Merging PR #5719 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5719. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.