fix(router): set correct redirect/default URL from hashchange#5683
Closed
btford wants to merge 1 commit intoangular:masterfrom
Closed
fix(router): set correct redirect/default URL from hashchange#5683btford wants to merge 1 commit intoangular:masterfrom
btford wants to merge 1 commit intoangular:masterfrom
Conversation
btford
added
hotlist: GT
action: review
btford
force-pushed
the
fix-router-default-route-url
branch
2 times, most recently
from
5d4fc67 to
6fbf95e
Compare
Contributor
|
LGTM. Please double check that the E2E errors are flaky and not code-related. |
btford
force-pushed
the
fix-router-default-route-url
branch
from
6fbf95e to
c1eaf86
Compare
Contributor
Author
|
@vsavkin can you pls review? 🍰 |
Contributor
Author
|
oh, wait, nvm, matias got it. |
btford
added
action: merge
Contributor
Author
|
Assuming this passes CI now, this should be good to go. |
btford
force-pushed
the
fix-router-default-route-url
branch
2 times, most recently
from
51460aa to
0a50d49
Compare
Currently, hashchange events outside of Angular that cause navigation do not take into account cases where the initial route URL changes due to a redirect or a default route. Closes angular#5590
btford
force-pushed
the
fix-router-default-route-url
branch
from
0a50d49 to
170bed1
Compare
Contributor
Author
|
@jelbourn tests passing, please merge when you can! |
|
Merging PR #5683 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5683. |
|
Merging PR #5683 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5683. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, hashchange events outside of Angular that cause navigation do not take into account cases where the initial route URL changes due to a redirect or a default route.
Tracks internal bug b/26013076
Closes #5590