feat(testing): package angular2_testing to prepare it for publishing#5682
Closed
juliemr wants to merge 1 commit intoangular:masterfrom
Closed
feat(testing): package angular2_testing to prepare it for publishing#5682juliemr wants to merge 1 commit intoangular:masterfrom
juliemr wants to merge 1 commit intoangular:masterfrom
Conversation
juliemr
added
the
area: testing
Contributor
|
LGTM if LGT Travis. |
yjbanov
added
pr_state: LGTM
action: cleanup
juliemr
force-pushed
the
dart-testing-distro
branch
from
c44091e to
c164958
Compare
Member
Author
|
I added another task to make sure that LICENSE gets copied. I'm not thrilled with how this affects the gulpfile, but the code for other LICENSE copying is buried in the broccoli dart tree, so not easily reusable for the pure dart packages. All owners for angular2 have been added as owners for https://pub.dartlang.org/packages/angular2_testing |
juliemr
force-pushed
the
dart-testing-distro
branch
from
c164958 to
083d588
Compare
juliemr
force-pushed
the
dart-testing-distro
branch
from
083d588 to
0274993
Compare
juliemr
removed
the
action: cleanup
Member
Author
|
Travis is happy! |
|
Merging PR #5682 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5682. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.